short circuit friendly flow

pytube · Jul 14, 2018 · ed046d8 · ed046d8
1 parent 0649fcc
commit ed046d8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pytube/query.py b/pytube/query.py
@@ -171,7 +171,7 @@ def order_by(self, attribute_name):
             integer_attr_repr[attr] = int(''.join(num)) if num else None
 
         # if every attribute has an integer representation
-        if all(integer_attr_repr.values()) and integer_attr_repr:
+        if integer_attr_repr and all(integer_attr_repr.values()):
             def key(s): return integer_attr_repr[getattr(s, attribute_name)]
         else:
             def key(s): return getattr(s, attribute_name)