Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix parses the throttling array javascript error nontype #1166

Closed

Conversation

thinhpm
Copy link

@thinhpm thinhpm commented Nov 22, 2021

Fix error 'NoneType' object has no attribute 'span'

@Derpiesaurus
Copy link

Not sure if people usually are able to publicly show a like for a pull request as I don't use my Github account often, but I don't see a button so I'll comment that this worked perfectly, so thank you!

@glubsy
Copy link
Contributor

glubsy commented Nov 22, 2021

Perhaps changing the regex would be beneficial as well, as mentioned here.

Also adding some tests to the test suite would be a good idea.

@RONNCC
Copy link
Collaborator

RONNCC commented Feb 4, 2022

hey @thinhpm

Thanks for the PR!

If this is still relevant, could you add the following:

  • a unit test to show the behavior before and after
  • some context on the need for the change

Ideally this would 'break' in the future when youtube also changes behavior again and we can show it as a regression

@RONNCC RONNCC closed this May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants