fixed regex match error #1336
Closed
fixed regex match error #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why wasn't this merged ? |
|
@1hachem seems like I'm not the only one who ended up here today... just tried to download a video and out of no where pytube stopped working. Did you ? Any idea why this patch was not needed yesterday ? |
|
No idea why it stopped working, but it seems that this keeps happening from time to time, it works that it doesn't than it works again, and this is why they didn't patch it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this bug #1199
Essentially the fix is just updating the regular expression. Tested locally and download is working after the fix on Ubuntu 20.04.