Get rid of six dependency #358
Conversation
|
I somehow can't get Travis to run on this commit/PR... |
|
@z3ntu Thanks, but I doubt this change would go over well with some users. Feel free to leave it open, maybe in 2025 it'll be safe to do it. |
z3ntu
force-pushed
the
no_more_six
branch
2 times, most recently
from
32453dd
to
7f5c09c
Compare
|
Now Travis is running. I'm also dropping the link https://python3statement.org/ here; I think Python 2 can be dropped before that, as Python 2 users can still use old release of pyudev. Anyways, it's your decision, I just dropped this PR here :) |
|
Ok, thanks! Looks like I need to do a pass to fix up some of the CI first, though. |
|
Restarted Travis... |
|
Looks like the remaining Travis errors are actually occasioned by this PR. So, they would require further investigation as well. |
|
Tests now succeed for all 3.x versions and fail for 2.x (so 2.7 and pypy) |
|
Ok, thanks! |
|
Just looking through my old forks, is this still wanted in pyudev? I see py2 support has been dropped more than a year ago but six is still required. |
|
Thank you for checking. I hope to cut a new release that officially drops py2 support in maybe a week. If you have time could you close this PR and make a new one against master branch? |
z3ntu
force-pushed
the
no_more_six
branch
2 times, most recently
from
b96ae28
to
fb3405a
Compare
|
CI is green for me now: https://github.com/z3ntu/pyudev/actions/runs/1714699866 |
|
@z3ntu Plz rebase one last time and I'll be able to merge immediately. Thx! |
Python 2 support is dropped, so time to remove six.
As per last commit six is not required anymore.
|
Also removed six dependency from CI now. CI is green again: https://github.com/z3ntu/pyudev/actions/runs/1799264471 |
|
thx! |
Obviously this makes pyudev incompatible with Python 2 but Python 2 will
be dead soon anyways.
https://pythonclock.org/