Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object-oriented approach for asset resolver #73

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

rayzchen
Copy link
Collaborator

@rayzchen rayzchen commented Jul 1, 2023

This can be used later for asset resolving in projects, or more general asset loading (for example used by the PyUnity Editor and its assets).

@rayzchen rayzchen added Type: Enhancement New feature or request Topic: Module Bugs or enhancements to do with PyUnity code OS: Any Occurs on any platform labels Jul 1, 2023
@rayzchen rayzchen self-assigned this Jul 1, 2023
@rayzchen rayzchen added this to the 0.9.0 milestone Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #73 (3ef9292) into develop (fee9190) will increase coverage by 0.36%.
The diff coverage is 76.14%.

@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
+ Coverage    53.92%   54.28%   +0.36%     
===========================================
  Files           33       33              
  Lines         5089     5143      +54     
===========================================
+ Hits          2744     2792      +48     
- Misses        2345     2351       +6     
Impacted Files Coverage Δ
pyunity/info.py 0.00% <0.00%> (ø)
pyunity/resources.py 73.78% <74.72%> (+18.88%) ⬆️
pyunity/gui.py 57.76% <100.00%> (ø)
pyunity/loader.py 65.24% <100.00%> (ø)
pyunity/render.py 30.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rayzchen rayzchen merged commit f9661cb into develop Jul 3, 2023
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Any Occurs on any platform Topic: Module Bugs or enhancements to do with PyUnity code Type: Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant