Add support to build with ITK5 (and keep support for ITK4) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' variable The `it` variable is declared twice, in the initialiser of the for loop and inside the for loop. This commit fixes the issue so that we can build without `-Wshadow`.
… ITK5. Since ITK5, descendents of `itk::InterpolateImageFunction` must implement the `GetRadius()` which is a pure virtual method in the parent. This method is not present in ITK so preprocessing logic is added to hide it when building with ITK4.
The vnl_math_* functions were deprecated in ITK sometime ago (not sure when but ITK 4.10 actively replaced its use internally) and are no longer present in ITK 5.2. Moving forward, ITK recommends the use of equivalent functions in the standard library or, if that's not possible, to use itk::Math::* (see Utilities/ITKv5Preparation/replace_vnl_math_XXX.sh in ITK sources).
The vcl_* functions were deprecated in ITK sometime ago (not sure when but ITK 4.10 actively replaced its use internally) and are no longer present in ITK 5.2. ITK recommends the use of equivalent functions in the standard library (see Utilities/Maintenance/VCL_ModernizeNaming.py in ITK sources).
carandraug
force-pushed
the
itk5-support
branch
from
f55be09
to
50fe49a
Compare
This was referenced Dec 8, 2023
|
Gentle ping. Would be nice to have these merged and the changes appear trivial. |
|
This will look much simpler if reviewed one commit at a time instead (all details are on the individual commit messages). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert3D does not currently build with ITK5. There are a series of very minor changes required. This pull request implements them (and keeps support to build with ITK4).