Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyconfr 2019: add peertube links #999

Merged
merged 2 commits into from Oct 24, 2020

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Mar 14, 2020

PyConFR 2019: add peertube links

Based on #998 in order to preventively fix the conflict.

Notify @JulienPalard.

There was an audio issue, video has been updated.
@JulienPalard
Copy link
Contributor

Wow.

@pilou- pilou- force-pushed the pyconfr-2019-add-peertube-links branch from 93a64ca to 57f4d80 Compare March 14, 2020 15:24
@pilou-
Copy link
Contributor Author

pilou- commented Mar 14, 2020

Updated: remove extraneous comma

@redapple
Copy link
Collaborator

Thanks @pilou-
I'm not familiar with PeerTube.

For YouTube and Vimeo, PyVideo.org embeds the videos in an <iframe> (see https://github.com/pyvideo/pyvideo/blob/190542b9863e06a91def2c54d81e24e09e087f20/plugins/json_reader.py#L142)

My questions to you:

  • do all PeerTube videos follow https://<instance.name>/videos/watch/<uuid>?
  • could we use a unique "peertube" type and transform these using https://<instance.name>/videos/embed/f04c14bf-8ac1-4b1e-bfc0-14caa80a1674 to be used in an iframe?
    if yes, I'd rather we adapt the pelican plugin to transform PeerTube URLs to embeddable ones before merging these new URLs.

@pilou-
Copy link
Contributor Author

pilou- commented Apr 1, 2020

My questions to you:

* do all PeerTube videos follow `https://<instance.name>/videos/watch/<uuid>`?

Yes, here are some examples:

Should I added these URLs too ?

* could we use a unique "peertube" type and transform these using `https://<instance.name>/videos/embed/f04c14bf-8ac1-4b1e-bfc0-14caa80a1674` to be used in an `iframe`?

Yes, using videos/embed/<id>, for example: https://bittube.video/videos/embed/4de251dd-f919-41c3-81a5-d5767904f6c7.

  if yes, I'd rather we adapt the pelican plugin to transform PeerTube URLs to embeddable ones before merging these new URLs.

A proposal: pyvideo/pyvideo#269

@logston
Copy link
Member

logston commented Oct 24, 2020

Wow! Sorry for the long delay on this!

@logston logston merged commit aa4182b into pyvideo:master Oct 24, 2020
@pilou- pilou- deleted the pyconfr-2019-add-peertube-links branch October 24, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants