-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 2 support and support Pyvisa >= 1.11 #53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
Coverage ? 86.10%
=========================================
Files ? 14
Lines ? 1015
Branches ? 0
=========================================
Hits ? 874
Misses ? 141
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@MatthieuDartiailh I'm sorry if my question is trivial, but I don't know how to point to the new version of pyvisa-sim, as there is no new release, in my requirements.txt file. Can you tell me how to test your code change? I load things with
and, when I do, GitHub actions automatically load these packages
|
Based on this stack overflow thread (https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source) the following line should work (you need to have git on your path): git+git://github.com/pyvisa/pyvisa-sim@drop-py2#egg=pyvisa_sim |
The issue is fixed with the change you made. |
Thanks for testing. I will do my best to merge and publish a release tonight. |
Should close #52
Please test this pass the tests but I do not have anything more involved to test it on.