Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 support and support Pyvisa >= 1.11 #53

Merged
merged 11 commits into from
Oct 15, 2020
Merged

Conversation

MatthieuDartiailh
Copy link
Member

Should close #52

Please test this pass the tests but I do not have anything more involved to test it on.

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@af4ba31). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage          ?   86.10%           
=========================================
  Files             ?       14           
  Lines             ?     1015           
  Branches          ?        0           
=========================================
  Hits              ?      874           
  Misses            ?      141           
  Partials          ?        0           
Flag Coverage Δ
#unittests 86.10% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4ba31...7d4621f. Read the comment docs.

@Arkh42
Copy link

Arkh42 commented Oct 13, 2020

@MatthieuDartiailh I'm sorry if my question is trivial, but I don't know how to point to the new version of pyvisa-sim, as there is no new release, in my requirements.txt file. Can you tell me how to test your code change?

I load things with

pyvisa >= 1.9
pyvisa-sim >= 0.3

and, when I do, GitHub actions automatically load these packages

Collecting pyvisa>=1.9
  Downloading PyVISA-1.11.1-py3-none-any.whl (188 kB)
Collecting pyvisa-sim>=0.3
  Downloading PyVISA-sim-0.3.tar.gz (41 kB)

@MatthieuDartiailh
Copy link
Member Author

Based on this stack overflow thread (https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source) the following line should work (you need to have git on your path):

git+git://github.com/pyvisa/pyvisa-sim@drop-py2#egg=pyvisa_sim

@Arkh42
Copy link

Arkh42 commented Oct 14, 2020

The issue is fixed with the change you made.
Thanks for your very quick reaction!

@MatthieuDartiailh
Copy link
Member Author

Thanks for testing. I will do my best to merge and publish a release tonight.

@MatthieuDartiailh MatthieuDartiailh merged commit 530630d into master Oct 15, 2020
@bors bors bot deleted the drop-py2 branch October 15, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyvisa doesn't found pyvisa-sim with pyvisa 1.11.0
3 participants