Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have net positive code coverage diff requirement on PRs? #1906

Closed
banesullivan opened this issue Dec 1, 2021 · 1 comment · Fixed by #1993
Closed

Should we have net positive code coverage diff requirement on PRs? #1906

banesullivan opened this issue Dec 1, 2021 · 1 comment · Fixed by #1993

Comments

@banesullivan
Copy link
Member

Should we implement a hard CI check that requires a net positive code coverage on the diff? This would help ensure we are writing decent tests but I could also see it being a bit of a nuisance

@MatthewFlamm
Copy link
Contributor

I think it should be implemented, but ignored when it makes sense. For example, a style-only change that touches several modules should not be required to have net positive code coverage, but new feature additions should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants