Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open an Issue when linkcheck fails #3268

Open
laysauchoa opened this issue Sep 4, 2022 · 17 comments
Open

Open an Issue when linkcheck fails #3268

laysauchoa opened this issue Sep 4, 2022 · 17 comments
Assignees
Labels
feature-request Please add this cool feature! testing Anything related to CI testing

Comments

@laysauchoa
Copy link

laysauchoa commented Sep 4, 2022

Describe the feature you would like to be added.

Problem
Recently, we have added linkcheck to run periodically, every week. However, someone has to go and look for the failed build and do the fixes. This could go unseen or unnoticed.

Proposed solution
Automatically open an Issue when the linkcheck fails. So we can better monitor it and fix it. We can also assign to some of the maintainers

I will be happy to work on that

@laysauchoa laysauchoa added the feature-request Please add this cool feature! label Sep 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

Hi and welcome! Thanks for posting your first issue in the PyVista project! Someone from @pyvista/developers will chime in before too long. If your question is support related, we may transfer it to the Discussions.

@tkoyama010
Copy link
Member

tkoyama010 commented Sep 4, 2022

It is a great idea to have auto Pull Requests issue. We always welcome your contribution.

@laysauchoa
Copy link
Author

@tkoyama010 this would be more like an issue saying that it failed, not the pull request with the fix.

@tkoyama010
Copy link
Member

I'm sorry. I misunderstood your suggestion (I was imagining something like dependabot.). In this case, I also think Issue would be better.

@tkoyama010
Copy link
Member

First of all, we don't know the correct URL automatically 😅

@banesullivan
Copy link
Member

@laysauchoa, I think this is a great idea. Would you be willing to take this on?

I believe there are GitHub Actions that can open an issue like this easily.

I would set up the CI on a cronjob which:

  1. runs link check and captures output as text
  2. if fails, opens the issue with error text as body of the issue

@adeak
Copy link
Member

adeak commented Sep 8, 2022

@laysauchoa, I think this is a great idea. Would you be willing to take this on?

I believe there are GitHub Actions that can open an issue like this easily.

I would set up the CI on a cronjob which:

  1. runs link check and captures output as text
  2. if fails, opens the issue with error text as body of the issue

@laysauchoa humbly didn't link to it, but we already have #3166 thanks to them :) this machinery could be upgraded to open the issue.

@adeak adeak added the testing Anything related to CI testing label Sep 8, 2022
@banesullivan
Copy link
Member

Ah, thanks for pointing that out @adeak, and thank you @laysauchoa for already implementing most of this!

@laysauchoa
Copy link
Author

Opening the issue works fine but I tried to catch the output from previous steps to add to the body of the issue and does not work because the GitHub action that I use for the issue does not support such a long output. I am trying to find an alternative for that, but so far nothing worked.

@banesullivan
Copy link
Member

Do you have a prototype of the code pushed somewhere? I'd be happy to help

@laysauchoa
Copy link
Author

Hi @banesullivan I think it can be something like the PR I linked

@laysauchoa
Copy link
Author

can this issue be eligible for the hacktoberfest? If yes, can we add the label for it? thanks!

@adeak
Copy link
Member

adeak commented Oct 23, 2022

can this issue be eligible for the hacktoberfest? If yes, can we add the label for it? thanks!

My understanding is that PRs are what are eligible, and approved, merged PRs are valid automatically. That being said, @tkoyama010 diligently labels our merged PRs for hacktoberfest :)

@tkoyama010
Copy link
Member

I mistook this for a PR, it is an ISSUE.

@laysauchoa
Copy link
Author

Alright, clear! Thanks for clarifying :)

@laysauchoa
Copy link
Author

Can I assign this issue to me? I've an open pull request about it.

@adeak
Copy link
Member

adeak commented Oct 23, 2022

Can I assign this issue to me? I've an open pull request about it.

I don't think you can, but I've assigned you now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Please add this cool feature! testing Anything related to CI testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants