Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test to check that all images in the cache are utilized by a test #3453

Open
MatthewFlamm opened this issue Oct 12, 2022 · 1 comment
Labels
maintenance Low-impact maintenance activity

Comments

@MatthewFlamm
Copy link
Contributor

MatthewFlamm commented Oct 12, 2022

Describe what maintenance you would like added.

#3336 added a image cache file for closing_and_mem_cleanup.png despite the fact that this test does not cache a plotter image. In fact, the image should have a basic sphere in this test, so the image is also wrong.

def test_closing_and_mem_cleanup():
n = 5
for _ in range(n):
for _ in range(n):
p = pyvista.Plotter()
for k in range(n):
p.add_mesh(pyvista.Sphere(radius=k))
p.show()
pyvista.close_all()

It would be useful to have a test, in some form, that ensures that all images are referenced in a test to avoid this kind of problem in the future.

@MatthewFlamm MatthewFlamm added the maintenance Low-impact maintenance activity label Oct 12, 2022
@MatthewFlamm
Copy link
Contributor Author

A complicating factor to this is that some tests only cache images on certain vtk versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

No branches or pull requests

1 participant