Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_osmnx_graph produces a deprecation warning for the shapely package #5812

Closed
user27182 opened this issue Mar 21, 2024 · 1 comment · Fixed by #6107
Closed

download_osmnx_graph produces a deprecation warning for the shapely package #5812

user27182 opened this issue Mar 21, 2024 · 1 comment · Fixed by #6107
Labels
maintenance Low-impact maintenance activity

Comments

@user27182
Copy link
Contributor

user27182 commented Mar 21, 2024

Describe what maintenance you would like added.

Running

pip install pyvista osmnx | python -c "from pyvista.examples.downloads import download_osmnx_graph; download_osmnx_graph()"

Gives a deprecation warning:

UserWarning: Unpickling a shapely <2.0 geometry object. Please save the pickle again; shapely 2.1 will not have this compatibility.
  return pickle.load(open(filename, 'rb'))

This dataset was originally added in #1611

cc @akaszynski

EDIT:
The maintenance to be done is perhaps to update the example? Or maybe add a note to the example about the shapely version requirements.

Link to the docs page for this example: link
Line generating the warning:

return pickle.load(open(filename, 'rb'))

Note: This warning was found while running some tests locally as part of #5787

Links to source code.

No response

Pseudocode or Screenshots

No response

@user27182 user27182 added the maintenance Low-impact maintenance activity label Mar 21, 2024
@akaszynski
Copy link
Member

Let's drop this example. I think we already have a ton of dependencies in our examples, and we might consider separating out some of our extended examples into a separate repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants