Fix mapping onto pixel for line #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Happy to see it merged once you check for other similar issues. |
jbednar
approved these changes
Sep 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a line was clipped, the computed end point on the bounds could be mapped to a pixel outside the bounds because of floating point error. This showed up as #570.
There should be no change for points or triangles. However:
The code changes and comments should be reviewed carefully.
(The various 'build map for x' (and similar) functions seem a bit clumsy; should consider reorganizing the code a bit in the future. Have avoided doing that here so as not to confuse things.)