Fixes #8: Use dict on py>=3.7; Improved exceptions, and mapping vs iterable #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
changed the title
andy-maier
force-pushed
the
andy/reduce-ordereddict
branch
2 times, most recently
from
507b603
to
fc459a8
Compare
andy-maier
force-pushed
the
andy/reduce-ordereddict
branch
from
fc459a8
to
0610485
Compare
andy-maier
changed the title
andy-maier
force-pushed
the
andy/reduce-ordereddict
branch
4 times, most recently
from
2c7f18c
to
4608943
Compare
Details: * Starting with Python 3.7, the standard dict is guaranteed to be ordered on all Python implementations. Therefore, there is no reason to use OrderedDict anymore on py>=3.7, and the standard dict is faster. This change uses dict on py>=3.7 and otherwise OrderedDict for the implementation of NocaseDict. * The issuing of message 'During handling of the above exception, another exception occurred' is now suppressed by setting exc.__cause__ = None. This works on both Python 2 and 3. * Improved the detection of mapping vs iterable as the init argument by generalizing the type checking for mapping to be derived from (NocaseDict, Mapping, UserDict), and to expect an iterable otherwise, failing with TypeError when it cannot be iterated on. * Exception messages have been cleaned up and improved, and in some cases re-raised with better message. No different exception types are raised than before this change. * Along with the new re.-raising of exceptions, it surfaced that some error cases had not been tested so far, mainly in the area of providing iterables of tuples (key, value) where the tuple items did not contain exactly two items. Added testcases to cover these error cases. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier
force-pushed
the
andy/reduce-ordereddict
branch
from
4608943
to
8af5101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
Note: It is not worth reviewing the docstrings of this PR, as the docs are updated in PR #5