Docs: Fixed missing Python 2 only methods in docs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
changed the title
Details: * The environment variable DOCS_SHOW_ALL that controls whether the python 2 only methods are not removed when docs are built, was set in the Makefile. That worked in a local docs build, but not for the RTD docs build because that one invoked Sphinx directly. Fixed that by moving the setting of the env var into docs/conf.py, removing it from the Makefile. * Renamed the variable to BUILDING_DOCS for better clarity. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier
force-pushed
the
andy/fix-docs
branch
from
f674cba
to
d6fbd2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
No review needed.