Migrated from Travis and Appveyor to GitHub Actions #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/migrate-to-actions
branch
4 times, most recently
from
77297c2
to
84fe893
Compare
andy-maier
force-pushed
the
andy/migrate-to-actions
branch
4 times, most recently
from
8dee111
to
d0cc924
Compare
KSchopmeyer
reviewed
Nov 16, 2020
KSchopmeyer
reviewed
Nov 16, 2020
There was a problem hiding this comment.
Note that there are some security vulnerabilities (bleach and psutils) marked if you clock on the code for this branch. https://github.com/pywbem/pywbem/network/alerts
Andy: Let's solve them separately.
andy-maier
force-pushed
the
andy/migrate-to-actions
branch
10 times, most recently
from
3a4579e
to
0a0c16d
Compare
Details: * Removed appveyor.yml and .travis.yml. * Removed badges for Travis and Appveyor in README. * Added badge for GitHub Actions in README. * Added GitHub Actions workflow file test.yml. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Details: * Ensured in the Makefile that pip before v9 is always first upgraded to 9.0.1 before again upgraded according to the requirements and constraint files. This is necessary because Pip started supporting the complete set of environment markers only in version 9.0.1. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Details: * In Github Actions with Python 3.4, a new virtualenv has pip version 8.0.0, but that version of pip does not yet support env marker 'implementation_name'. Fixed that by upgrading pip to >=9.0.1 in the new virtualenv before the install of the dependent packages. * In Github Actions, Python is not installed in a virtualenv, so the saving and restoring of the virtualenv in test_install.sh has been made conditional to running in a virtualenv. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Details: * typed-ast was missing in dev-requirements.txt. astroid needs it on Python >=3.4 and Python <=3.7 and only on CPython. Added an according dependency. * Changed the typed-ast version to match what astroid uses. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
…ctions Details: * On Windows runs in GitHub Actions with minimum package levels, safety is at version 1.8.4. This version fails with a UnicodeEncodeError due to cp1256 being used by Click on that Windows system. The fix that addresses this issue in safety has already been released in safety 1.8.2, so it is strange that 1.8.4 still fails. Trying with safety version 1.9.0. * Increased minimum versions of pyyaml to address safety issues. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Details: * Increased minimum version of 'coverage' to 5.0 in order to be able to specify 'relative_files=True" in the 'coveragerc' config file, which causes the file paths in the .coverage data file to be relative. This was originally needed to use a github app for reporting to coveralls (which is no longer used), but it seems like a good idea in general. * Because coverage 5.0 does not support Python 3.4, disabled generating and reporting coverage data in the makefile, test.yml workflow file, and when installing dependent packages in the requirements and constraint files. * Migrated from 'python-coveralls' to 'coveralls' because the former does not support GitHub Actions in parallel mode (it picks the run ID that is used by coveralls.io to combine the reports automatically from Travis and does neither allow specifying it from the outside, nor does it support other CI systems than Travis). Also, python-coveralls does not seem to be maintained anymore and its last officially supported Python version is 3.6. * Since 'coveralls' 2.x only supports Python 3.5 and upwards, and 'coveralls' 1.x is incompatible with the run ID, a fork of 'coveralls' 2.x with Python 2.7 backport support is used on Python 2.7. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier
force-pushed
the
andy/migrate-to-actions
branch
from
0a0c16d
to
d909c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.