Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvented Pylint issue with similar lines #79

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

andy-maier
Copy link
Contributor

See commit message.
No review needed.

Details:

* Starting with pylint 2.7.0, pylint seems to ignore the min-similarity-lines
* setting and reports 8 similar lines in some test files. This change increases
  the acceptable number of similar lines to 40, but because of the pylint
  behavior it also temporarily disabled pylint issue R0801 as a temporary
  way to circumvent the issue.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier self-assigned this Feb 22, 2021
@andy-maier andy-maier added this to the 1.0.3 milestone Feb 22, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ead98db on andy/fix-pylint-similarities into 1eaafa2 on master.

@andy-maier andy-maier merged commit 074bafd into master Feb 22, 2021
@andy-maier andy-maier deleted the andy/fix-pylint-similarities branch February 22, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants