Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Python version inconsistencies (e.g. clear()) #31

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Resolved Python version inconsistencies (e.g. clear()) #31

merged 1 commit into from
Jul 28, 2020

Conversation

andy-maier
Copy link
Contributor

See commit message.

@andy-maier andy-maier self-assigned this Jul 28, 2020
@andy-maier andy-maier added this to the 1.0.1 milestone Jul 28, 2020
@andy-maier andy-maier linked an issue Jul 28, 2020 that may be closed by this pull request
Support clear() also on Python 2 #30
Closed
@andy-maier andy-maier mentioned this pull request Jul 28, 2020
Closed
@coveralls
Copy link

coveralls commented Jul 28, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 1ce74f3 on andy/consistent-py into 7b98bb7 on master.

@andy-maier andy-maier force-pushed the andy/consistent-py branch 4 times, most recently from 169d8b3 to 127420b Compare July 28, 2020 09:20
@andy-maier
Resolved Python version inconsistencies (e.g. clear())
1ce74f3 
Details:

* Added support for the clear() method also when on Python 2.

* Enabled two testcases in the test for __contains__() that had
  been disabled for no reason.

* Moved the paragraph that already claimed that NocaseList supports
  all functionality of the built-in list as of py38 on all py versions,
  to the README and to the intro of the docs, and simplified it.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier merged commit 72f4154 into master Jul 28, 2020
@andy-maier andy-maier deleted the andy/consistent-py branch July 28, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSchopmeyer KSchopmeyer KSchopmeyer approved these changes

Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

Support clear() also on Python 2
3 participants
@andy-maier @coveralls @KSchopmeyer