Cleaned up module wildcard imports in pywbem_mock

Details:

* Some pywbem_mock submodules were missing the '__all__' variable. This caused
  all names defined in and imported into the submodule to become visible in
  the 'pywbem_mock' namespace, which is undesirable.
  Added '__all__' where missing, with only the intended public names.

* Fixed use of incorrectly imported names in unit tests, that were used
  from the 'pywbem_mock' namespace. Used them from their defining submodules.

* Added import of the 'config' submodule into the 'pywbem_mock' namespace,
  in order to make sure that it is impoirted only once wnd that config variables
  can be modified.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>

pywbem_mock/__init__.py

@@ -23,6 +23,13 @@
 
 from __future__ import absolute_import
 
+# The config namespace is imported as a sub-namespace to make the config
+# variables accessible directly via their defining namespace. Importing
+# them into the pywbem_mock namespace would duplicate their names and thus
+# would cause changes to the config variables not to be visible in their
+# original namespace.
+from . import config  # noqa: F401
+
 from ._wbemconnection_mock import *        # noqa: F403,F401
 from ._dmtf_cim_schema import *            # noqa: F403,F401
 from ._resolvermixin import *              # noqa: F403,F401
@@ -38,5 +45,4 @@
 from ._methodprovider import *             # noqa: F403,F401
 from ._namespaceprovider import *          # noqa: F403,F401
 from ._subscriptionproviders import *      # noqa: F403,F401
-
 from ._utils import *                      # noqa: F403,F401

pywbem_mock/_baseprovider.py

@@ -46,6 +46,8 @@
 # pywbem_mock implementation configuration variables that are used in
 # request responsders.
 
+__all__ = ['BaseProvider']
+
 
 class BaseProvider(object):
     """

pywbem_mock/_baserepository.py

@@ -48,6 +48,8 @@
 from abc import abstractmethod, abstractproperty
 from six import PY2
 
+__all__ = ['BaseObjectStore', 'BaseRepository']
+
 
 def compatibleabstractproperty(func):
     """

pywbem_mock/_mainprovider.py

@@ -73,6 +73,7 @@
 # The following config items only apply to open/pull operations
 from .config import DEFAULT_MAX_OBJECT_COUNT, OPEN_MAX_TIMEOUT
 
+__all__ = ['MainProvider']
 
 # per DSP0200, the default behavior for EnumerateInstance DeepInheritance
 # if not set by in the client request.  Default is True so that the mock server

pywbem_mock/_mockmofwbemconnection.py

@@ -34,6 +34,8 @@
 from pywbem._utils import _format
 from ._resolvermixin import ResolverMixin
 
+__all__ = []
+
 
 class _MockMOFWBEMConnection(ResolverMixin, BaseRepositoryConnection):
     """

pywbem_mock/_namespaceprovider.py

@@ -40,7 +40,6 @@
 from .config import OBJECTMANAGERNAME, SYSTEMNAME, SYSTEMCREATIONCLASSNAME, \
     OBJECTMANAGERCREATIONCLASSNAME
 
-
 __all__ = ['CIMNamespaceProvider']
 
 # CIM class name of the namespace class implemented in this provider

pywbem_mock/_providerdispatcher.py

@@ -52,6 +52,8 @@
 from ._instancewriteprovider import InstanceWriteProvider
 from ._methodprovider import MethodProvider
 
+__all__ = ['ProviderDispatcher']
+
 
 class ProviderDispatcher(BaseProvider):
     """

pywbem_mock/_resolvermixin.py

@@ -45,6 +45,8 @@
 
 from pywbem._utils import _format
 
+__all__ = []
+
 
 class ResolverMixin(object):  # pylint: disable=too-few-public-methods
     """

pywbem_mock/_subscriptionproviders.py

@@ -52,6 +52,9 @@
 from ._instancewriteprovider import InstanceWriteProvider
 from .config import SYSTEMNAME, SYSTEMCREATIONCLASSNAME
 
+__all__ = ['CIMIndicationFilterProvider', 'CIMListenerDestinationProvider',
+           'CIMIndicationSubscriptionProvider']
+
 # CIM class name of the classes implemented in these providers
 SUBSCRIPTION_CLASSNAME = 'CIM_IndicationSubscription'
 FILTER_CLASSNAME = 'CIM_IndicationFilter'

pywbem_mock/_utils.py

@@ -30,6 +30,8 @@
 
 import six
 
+__all__ = []
+
 STDOUT_ENCODING = getattr(sys.stdout, 'encoding', None)
 if not STDOUT_ENCODING:
     STDOUT_ENCODING = locale.getpreferredencoding()

pywbem_mock/_wbemconnection_mock.py

@@ -37,7 +37,6 @@
 #    from mock import Mock
 import six
 
-
 from pywbem import WBEMConnection, CIMClass, CIMClassName, \
     CIMInstance, CIMInstanceName, CIMParameter, CIMQualifierDeclaration, \
     cimtype, CIMError, CIM_ERR_FAILED, DEFAULT_NAMESPACE, MOFCompiler, \

tests/unittest/pywbem/test_subscriptionmanager.py

@@ -39,7 +39,7 @@
     CIMInstance, CIMDateTime, CIMError, CIM_ERR_ALREADY_EXISTS  # noqa: E402
 from pywbem._subscription_manager import SUBSCRIPTION_CLASSNAME, \
     DESTINATION_CLASSNAME, FILTER_CLASSNAME  # noqa: E402
-from pywbem_mock import OBJECTMANAGERNAME, \
+from pywbem_mock.config import OBJECTMANAGERNAME, \
     SYSTEMNAME  # noqa: E402
 pywbem_mock = import_installed('pywbem_mock')
 # pylint: enable=wrong-import-position, wrong-import-order, invalid-name

tests/unittest/pywbem_mock/test_wbemconnection_mock.py

@@ -79,8 +79,9 @@
 
 pywbem_mock = import_installed('pywbem_mock')
 from pywbem_mock import FakedWBEMConnection, DMTFCIMSchema, \
-    InstanceWriteProvider, MethodProvider, BaseProvider, \
-    IGNORE_INSTANCE_IQ_PARAM, IGNORE_INSTANCE_ICO_PARAM  # noqa: E402
+    InstanceWriteProvider, MethodProvider, BaseProvider  # noqa: E402
+from pywbem_mock.config import IGNORE_INSTANCE_IQ_PARAM, \
+    IGNORE_INSTANCE_ICO_PARAM  # noqa: E402
 # pylint: enable=wrong-import-position, wrong-import-order, invalid-name
 
 

tests/unittest/utils/wbemserver_mock.py

@@ -16,7 +16,7 @@
     CIMInstanceName  # noqa: E402
 pywbem_mock = import_installed('pywbem_mock')
 from pywbem_mock import FakedWBEMConnection  # noqa: E402
-from pywbem_mock import OBJECTMANAGERCREATIONCLASSNAME, \
+from pywbem_mock.config import OBJECTMANAGERCREATIONCLASSNAME, \
     SYSTEMCREATIONCLASSNAME, OBJECTMANAGERNAME, \
     SYSTEMNAME  # noqa: E402
 # pylint: enable=wrong-import-position, wrong-import-order, invalid-name