Skip to content

Commit

Permalink
Enabled coveralls again for Travis push events
Browse files Browse the repository at this point in the history
Details:

* The previous commit ran coveralls only for "pull_request" Travis event
  types in order to create only the PR comments linking to the result.
  However, for reasons not yet understood, the PR comments are not always
  created. The "push" Travis event at least creates a result link in the
  section on checks, but it sometimes does not show the delta.

  At this point, it seems most sensible to run coveralls on both event
  types.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
  • Loading branch information
andy-maier committed Oct 24, 2019
1 parent 458d2ef commit c199e04
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,6 @@ after_success:
# make sure this project is enabled there.
# Make sure the Python version matches the one specified for python-coveralls
# in dev-requirements.txt.
# On TRAVIS_EVENT_TYPE values: "pull_request" is important because it compares
# the branch to its merge target. It creates/updates a single comment with the
# results. "push" seems to compare to previous pushes and thus not always has
# a reasonable result.
- if [[ "$TRAVIS_EVENT_TYPE" == "pull_request" && "$TRAVIS_OS_NAME" == "linux" && "$TRAVIS_PYTHON_VERSION" == "3.4" && "$PACKAGE_LEVEL" == "latest" && -z $_MANUAL_CI_RUN ]]; then
- if [[ "$TRAVIS_OS_NAME" == "linux" && "$TRAVIS_PYTHON_VERSION" == "3.4" && "$PACKAGE_LEVEL" == "latest" && -z $_MANUAL_CI_RUN ]]; then
coveralls;
fi

0 comments on commit c199e04

Please sign in to comment.