Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code issue in IterQueryInstances #1334

Closed
KSchopmeyer opened this issue Aug 18, 2018 · 1 comment
Closed

Code issue in IterQueryInstances #1334

KSchopmeyer opened this issue Aug 18, 2018 · 1 comment
Assignees
@KSchopmeyer
Labels
area: code priority resolution: fixed type: bug
Milestone
0.13.0

Comments

@KSchopmeyer
Copy link
Collaborator

KSchopmeyer commented Aug 18, 2018 •
edited

The input parameters are reversed for the ExecQuery in the IterQueryInstances method. The call
puts the Query as the first parameter and the QueryLanguage as the second parameter.

I have no idea why I did not catch this before since it is tested in run_cimoperations.py.

Passed the mock tests because we don't really do anything in the mocker for the query.
@KSchopmeyer KSchopmeyer added this to the 0.13.0 milestone Aug 18, 2018
@KSchopmeyer KSchopmeyer self-assigned this Aug 18, 2018
KSchopmeyer added a commit that referenced this issue Aug 18, 2018
@KSchopmeyer
issue #1334 - Fix issue where IterQueryInstances params reversed
87a4d38 
Fixes issue #1334 where the parameters for QueryLanguage and Query were
reversed in the ExecQuery call that is the fallback if the
OpenQueryInstances fails or use_pull_operations is False.

Also fixes test results for this test (also reversed) and adds comment
to changes.rst
@KSchopmeyer KSchopmeyer mentioned this issue Aug 18, 2018
Merged
KSchopmeyer added a commit that referenced this issue Aug 19, 2018
@KSchopmeyer
issue #1334 - Fix issue where IterQueryInstances params reversed
027c327 
Fixes issue #1334 where the parameters for QueryLanguage and Query were
reversed in the ExecQuery call that is the fallback if the
OpenQueryInstances fails or use_pull_operations is False.

Also fixes test results for this test (also reversed) and adds comment
to changes.rst
andy-maier pushed a commit that referenced this issue Aug 19, 2018
@KSchopmeyer @andy-maier
issue #1334 - Fix issue where IterQueryInstances params reversed
3db7df3 
Fixes issue #1334 where the parameters for QueryLanguage and Query were
reversed in the ExecQuery call that is the fallback if the
OpenQueryInstances fails or use_pull_operations is False.

Also fixes test results for this test (also reversed) and adds comment
to changes.rst
@andy-maier andy-maier mentioned this issue Aug 19, 2018
Merged
@andy-maier
Copy link
Contributor

andy-maier commented Aug 19, 2018 •
edited

PR #1335 addresses this in the master branch (targeting 0.13.0).
PR #1345 rolls back this fix into the 0.12 fix stream (targeting 0.12.5).

@andy-maier andy-maier modified the milestones: 0.13.0, 0.12.5 Aug 19, 2018
andy-maier pushed a commit that referenced this issue Aug 19, 2018
@KSchopmeyer @andy-maier
issue #1334 - Fix issue where IterQueryInstances params reversed
2c8eb7a 
Fixes issue #1334 where the parameters for QueryLanguage and Query were
reversed in the ExecQuery call that is the fallback if the
OpenQueryInstances fails or use_pull_operations is False.

Also fixes test results for this test (also reversed) and adds comment
to changes.rst
andy-maier pushed a commit that referenced this issue Aug 19, 2018
@KSchopmeyer @andy-maier
issue #1334 - Fix issue where IterQueryInstances params reversed
d4482c7 
Fixes issue #1334 where the parameters for QueryLanguage and Query were
reversed in the ExecQuery call that is the fallback if the
OpenQueryInstances fails or use_pull_operations is False.

Also fixes test results for this test (also reversed) and adds comment
to changes.rst
andy-maier pushed a commit that referenced this issue Aug 22, 2018
@KSchopmeyer @andy-maier
issue #1334 - Fix issue where IterQueryInstances params reversed
c114451 
Fixes issue #1334 where the parameters for QueryLanguage and Query were
reversed in the ExecQuery call that is the fallback if the
OpenQueryInstances fails or use_pull_operations is False.

Also fixes test results for this test (also reversed) and adds comment
to changes.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KSchopmeyer KSchopmeyer

Labels
area: code priority resolution: fixed type: bug
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@KSchopmeyer @andy-maier