Increased M2Crypto to 0.30.1; Used M2Crypto on Windows #1248

andy-maier · 2018-05-11T12:24:12Z

For details, see the commit message.
Ready for review and merge.

For the review:

Try it out on Windows
Review the whole install process we now have on Windows (see install section)

coveralls · 2018-05-11T12:35:39Z

Coverage remained the same at 84.724% when pulling 3576940 on andy/new-m2crypto into bb3659f on master.

andy-maier · 2018-06-03T20:14:38Z

Rebased.

KSchopmeyer · 2018-06-04T14:18:23Z

Note: Since in the Readme we state that it is supported on python 2 and 3 we really need to clarify the readme.

KSchopmeyer · 2018-06-04T15:13:54Z

appveyor.yml

+  # The installation in pywbem_os_setup.bat installs swig but without generating
+  # the swig.exe shim file (using GenShim).
+  # See GenShim issue https://github.com/chocolatey/shimgen/issues/43
+  # Therefore, we install swig ihere in order to create the swig.exe shim file.


What is word ihere??

"here" with an "i" for vi insert mode ;-)
DONE.

KSchopmeyer

Also, right not the readme states:

Pywbem is a WBEM client and WBEM indication listener, written in pure Python. It runs on Python 2 and Python 3.

We need to clalrify that. Also we never stated which OS's it supports in the readme.

Finally, the readme shows the linux install and does not reference windows at all or indicate that there are any differences. Maybe time to point them to the detailed install for windows since that is what we really maintain.

KSchopmeyer · 2018-06-04T15:16:06Z

docs/intro.rst

@@ -108,7 +108,7 @@ Pywbem is supported in these environments:
 Limitations:

 * On Windows (native), pywbem is not supported on Python 2.6, because the
-  M2CryptoWin32/64 packages do not support Python 2.6.
+  M2Crypto package does not support Python 2.6.


Do you mean the M2Crypto windows package???

This PR changes from using the outdated M2CryptoWin32/64 packages to using the M2Crypto package, on Windows.

So should say that M2Crypto package on Windows does not support ...

That's what it says, if you read the whole sentence.

KSchopmeyer · 2018-06-04T15:37:19Z

docs/intro.rst

@@ -268,6 +263,8 @@ environment (i.e. without using a UNIX-like environment; for that, see

      > pip install pywbem

+.. _`Chocolatey package manager`: https://chocolatey.org/


Should we say more than just Chocolatey package manager and a url???

This is just the definition of a link target; it does not generate anything in the text. It is used a few lines up.

KSchopmeyer · 2018-06-04T15:41:42Z

I reviewed the files changes but want to go back and completely read the doc. Also I am fighting chocolatey right now on my windows install and will update you when I get through that.

KSchopmeyer · 2018-06-04T15:42:07Z

Which will be slow since windows just decided to do a major update.

KSchopmeyer

The readme just states python 2 and 3 but nothing about OS, etc.

Also in the readme we show a simple pip install on linux but just refer to the install instructions for anything else. I really don't think we want to duplicate the doc install but should probably clarify a bit more including the issue that python 2.6 windows is a NoNo

andy-maier · 2018-06-04T22:44:59Z

On updating the README: I don't think we should update the README to duplicate the complete information from the Installation section. I have updated the README to state that the installation method shown is for Linux and that other operating systems are described in the installation section.

I agree. What I was thinking was that we should state that we support on Linux, Windows, MAC Os and not that Windows python 2.6 is not supported because of M2Crypto since those are major characteristics and limits. Leave the example as it and refer to doc for everything else.

andy-maier · 2018-06-04T22:47:52Z

Open at this point for Karl:

Review the complete installation section of the documentation
Verify the documented installation approach on Windows

KSchopmeyer · 2018-06-05T01:32:16Z

Testing with windows. This is fun.

Found that the terminal has to be in admin mode since chocolatey accesses data in the C:/program files ... directory and that fails without admin mode. That, of course means a difference setup since this is not logical like sudo.
AM> DONE, added to use admin command prompt.
pywbem_os-setup.bat requires a parameter "develop" or "install" and that is not documented.
AM> DONE, added default of install when nothing is specified.
Got through that and got it to build m2crypto and hit the following issue:

Creating library build\temp.win-amd64-2.7\Release\SWIG_m2crypto.lib and object build\temp.win- amd64-2.7\Release\SWIG_m2crypto.exp
python setup.py bdist_wheel
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help

error: invalid command 'bdist_wheel'
Error: Command returned rc=1
AM> DONE, added an according trouble shooting entry.

Quit for night at that point

That was easy to fix. wheel not installed apparently. did pip install wheel and it worked.

KSchopmeyer · 2018-06-05T15:57:37Z

New comments:

Made it all the way through a pip install and clone download etc. on windows and tested by running wbemcli.

I propose that we change "and it is assumed that Chocolatey is installed" in the windows install section to "Chocolatey must be installed before running the above script." Just want to make that stand out since it is a PIA to do.
AM> DONE - Moved that into a new "prerequisites" item. I inserted such an item for all target platforms.
The script asks that either "develop" or "install" keywords be on the cmd line. a)That probably deserves more explanation and b) that should be in the doc.
AM> DONE - Changed .bat script to default to install, consistent with the .sh version.
I could not checkout all the links in the doc (ex. to pywbem_os_bat) because in the local builddoc they are broken.
AM> Only the download links cannot be checked out locally, but I checked them for the .sh version, and used the same approach for the .bat version, so I'm confident they will work.

I cannot explain some of the fits and starts in testing but it did work out when I cleaned everything out and started over.

I think with these comments it is ready to commit. Then, however, we should go through the testing again since this is so many lose parts all sort of flying in formation.

Congratulations on getting this one sorted out

andy-maier · 2018-06-06T16:41:40Z

This last commit is supposed to address all comments that were made.
If anything is not addressed, please make new comments.

andy-maier · 2018-06-07T21:19:15Z

I had to do a small fix with directory switching in pywbem_os_setup.bat

M2Crypto 0.29.0 introduced support for Windows again, so it is no longer necessary to use the very outdated M2CryptoWin32/64 packages. This change uses the M2Crypto package now also on Windows, and eliminates using M2CryptoWin32/64. To enable that, it increases the minimum version of M2Crypto to 0.30.1 (which has a fix for the Windows support introduced with 0.29.0). It also adds a pywbem_os_setup.bat script which installs OS-level dependencie for installing M2Crypto (e.g. its build requires swig, Win32/64OpenSSL). Addressed review comments * Updated README.rst file to scope shown installation approach to Linux. * Typo in appveyor.yml file. Addressed review comments (2) - Added prerequisites such as initial python packages, etc. to the installation sections of each platform. - The pywbem_os_setup.bat file got extended to perform install as a default when no argument is specified, consistent with the .-sh version. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>

andy-maier self-assigned this May 11, 2018

andy-maier added type: enhancement area: setup and removed area: setup type: enhancement labels May 11, 2018

andy-maier added this to the 0.13.0 milestone May 11, 2018

andy-maier mentioned this pull request May 11, 2018

Increased M2Crypto minimum version to 0.30.1 pywbem/pywbemtools#104

Merged

andy-maier force-pushed the andy/new-m2crypto branch 4 times, most recently from a13ef0a to eed9da3 Compare May 11, 2018 16:26

andy-maier changed the title ~~Increased M2Crypto minimum version to 0.30.0~~ [WIP] Increased M2Crypto minimum version to 0.30.0 May 11, 2018

andy-maier added the under work label May 11, 2018

andy-maier force-pushed the andy/new-m2crypto branch 16 times, most recently from 3c08754 to 4a823fb Compare May 13, 2018 10:11

andy-maier mentioned this pull request Jun 3, 2018

Timeout does not work as expected when connecting https server via M2Crypto package #1275

Closed

andy-maier added the priority label Jun 3, 2018

andy-maier force-pushed the andy/new-m2crypto branch from c95e7bf to f2b0099 Compare June 3, 2018 20:14

KSchopmeyer reviewed Jun 4, 2018

View reviewed changes

KSchopmeyer added discussion needed and removed review needed labels Jun 5, 2018

andy-maier force-pushed the andy/new-m2crypto branch from a906592 to 3576940 Compare June 6, 2018 16:50

andy-maier requested a review from KSchopmeyer June 6, 2018 16:51

andy-maier added review needed and removed discussion needed labels Jun 6, 2018

andy-maier force-pushed the andy/new-m2crypto branch 3 times, most recently from 8dd40fb to a0f1b3a Compare June 7, 2018 21:17

andy-maier force-pushed the andy/new-m2crypto branch from a0f1b3a to f6c7341 Compare June 7, 2018 21:31

andy-maier merged commit fb19a89 into master Jun 7, 2018

andy-maier deleted the andy/new-m2crypto branch June 7, 2018 22:09

andy-maier removed the review needed label Jun 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increased M2Crypto to 0.30.1; Used M2Crypto on Windows #1248

Increased M2Crypto to 0.30.1; Used M2Crypto on Windows #1248

andy-maier commented May 11, 2018 •

edited

coveralls commented May 11, 2018 •

edited

andy-maier commented Jun 3, 2018

KSchopmeyer commented Jun 4, 2018

KSchopmeyer Jun 4, 2018

andy-maier Jun 4, 2018

KSchopmeyer left a comment

KSchopmeyer Jun 4, 2018

andy-maier Jun 4, 2018

KSchopmeyer Jun 5, 2018

andy-maier Jun 6, 2018

KSchopmeyer Jun 4, 2018

andy-maier Jun 4, 2018

KSchopmeyer commented Jun 4, 2018

KSchopmeyer commented Jun 4, 2018

KSchopmeyer left a comment

andy-maier commented Jun 4, 2018 •

edited by KSchopmeyer

andy-maier commented Jun 4, 2018

KSchopmeyer commented Jun 5, 2018 •

edited by andy-maier

KSchopmeyer commented Jun 5, 2018 •

edited by andy-maier

andy-maier commented Jun 6, 2018

andy-maier commented Jun 7, 2018

		@@ -268,6 +263,8 @@ environment (i.e. without using a UNIX-like environment; for that, see

		> pip install pywbem

		.. _`Chocolatey package manager`: https://chocolatey.org/

Increased M2Crypto to 0.30.1; Used M2Crypto on Windows #1248

Increased M2Crypto to 0.30.1; Used M2Crypto on Windows #1248

Conversation

andy-maier commented May 11, 2018 • edited

coveralls commented May 11, 2018 • edited

andy-maier commented Jun 3, 2018

KSchopmeyer commented Jun 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KSchopmeyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KSchopmeyer commented Jun 4, 2018

KSchopmeyer commented Jun 4, 2018

KSchopmeyer left a comment

Choose a reason for hiding this comment

andy-maier commented Jun 4, 2018 • edited by KSchopmeyer

andy-maier commented Jun 4, 2018

KSchopmeyer commented Jun 5, 2018 • edited by andy-maier

KSchopmeyer commented Jun 5, 2018 • edited by andy-maier

andy-maier commented Jun 6, 2018

andy-maier commented Jun 7, 2018

andy-maier commented May 11, 2018 •

edited

coveralls commented May 11, 2018 •

edited

andy-maier commented Jun 4, 2018 •

edited by KSchopmeyer

KSchopmeyer commented Jun 5, 2018 •

edited by andy-maier

KSchopmeyer commented Jun 5, 2018 •

edited by andy-maier