Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Fixed ResourceWarning for not closing MOF compiler log file #2488

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Test: Fixed ResourceWarning for not closing MOF compiler log file #2488

merged 1 commit into from
Oct 5, 2020

Conversation

andy-maier
Copy link
Contributor

@andy-maier andy-maier commented Oct 5, 2020 •
edited

See commit message.

@andy-maier andy-maier self-assigned this Oct 5, 2020
@andy-maier andy-maier added this to the 1.1.0 milestone Oct 5, 2020
@andy-maier andy-maier linked an issue Oct 5, 2020 that may be closed by this pull request
ResourceWarning due to not closing moflog2.txt log file #2487
Closed
@andy-maier andy-maier mentioned this pull request Oct 5, 2020
Merged
@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited

Coverage Status

Coverage remained the same at 90.708% when pulling fd28a90 on andy/fix-moflog2 into 7decc9f on master.

@andy-maier
Test: Fixed ResourceWarning for not closing MOF compiler log file
fd28a90 
Details:

* This ResourceWarning was issued in only two environments:
  - native Windows, py38, latest
  - CygWin, py37, latest

  The root cause was that in test_mof_compiler.py, moflog2 file
  was opened but never closed.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier merged commit 72d786d into master Oct 5, 2020
@andy-maier andy-maier deleted the andy/fix-moflog2 branch October 5, 2020 20:51
@andy-maier andy-maier mentioned this pull request Oct 10, 2020
Closed
@andy-maier andy-maier linked an issue Oct 10, 2020 that may be closed by this pull request
ResourceWarnings in py3 during test #86
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSchopmeyer KSchopmeyer KSchopmeyer approved these changes

Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

ResourceWarning due to not closing moflog2.txt log file ResourceWarnings in py3 during test
3 participants
@andy-maier @coveralls @KSchopmeyer