Skip to content

Commit

Permalink
Fix issue with dependency more-itertools
Browse files Browse the repository at this point in the history
Modify dev-requirements.txt to limit version of more-itertools for
python >= 3.5. Eliminates bug where new release of more-tools did did
not limit python versions.

Complete the changes for Sphinx version limitations.
  • Loading branch information
KSchopmeyer authored and andy-maier committed Nov 15, 2021
1 parent 1fa32ca commit 3ab5185
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ pluggy>=0.13.0
colorama>=0.3.9,<0.4.0; python_version <= '3.4'
colorama>=0.4.0; python_version >= '3.5'

# more-itertools version 8.11 requires python 3.6, See issue #2796
more-itertools>=4.0.0,!=8.11.0; python_version < '3.6'
more-itertools>=4.0.0; python_version >= '3.6'

# Virtualenv
# Virtualenv 20.0.19 has an issue where it does not install pip on Python 3.4.
# Virtualenv 20.0.32 has an issue where it raises AttributeError on Python 3.4.
Expand Down
3 changes: 3 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ Released: not yet
* Fixed issue with Sphinx and python 2.7 by changing the sphinx requirements
in dev-requirements.txt and minimum-constraints.txt. (see issue #1070)

* Modify dev-requirements.txt to limit version of more-itertools to < 8.10.1
for python < 3.6. (see issue #1077)

**Enhancements:**

* Enhanced test matrix for push-driven runs on GitHub Actions to add
Expand Down
2 changes: 1 addition & 1 deletion minimum-constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ jupyter_core==4.2.1
linecache2==1.0.0
MarkupSafe==0.23
mistune==0.8.1
more-itertools==5.0.0
more-itertools==4.0.0
nbconvert==5.0.0
nbformat==4.2.0
notebook==4.3.1
Expand Down

0 comments on commit 3ab5185

Please sign in to comment.