Fixes #556: connection list table #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
changed the title
KSchopmeyer
force-pushed
the
ks/#556-connection-list-table
branch
from
d097656
to
99e8831
Compare
Modify connection list table to have a brief table form that shows only name, server, and mock_server columns and an option --full for a display of all of the fields (except password and ca-certs which were never displayed). Remove the option that hides empty columns of the table so that all columns in the defined list show even if there is no data in the column. Added tests for the new table format. Modified the docs/pywbemcli/commands.rst to show this option and show the tables with and without the option.
KSchopmeyer
force-pushed
the
ks/#556-connection-list-table
branch
from
99e8831
to
2bd3add
Compare
andy-maier
reviewed
Apr 5, 2020
andy-maier
reviewed
Apr 5, 2020
andy-maier
reviewed
Apr 5, 2020
1. Changed text of --full help. 2 Changed text in commands.rst about not displaying all fields.
andy-maier
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new connection list table with only 3 columns. and flag in connection list to select the full table
Remove the hide-empty-rows from the current table output which is the --full table.
Add tests and modify doc