Fixes #594: Simplify output and implement TEXT output group #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSchopmeyer
changed the title
andy-maier
changed the title
|
Fails tests. |
KSchopmeyer
force-pushed
the
ks/#594-add-text-outputfmt
branch
from
475b15e
to
847b2ae
Compare
andy-maier
reviewed
May 9, 2020
andy-maier
reviewed
May 9, 2020
andy-maier
requested changes
May 9, 2020
Implements a new output format group (TEXT) and modifies two commands to use this group (server interop, and server brand). This removes the table option for these commands. It also implements the text output format as an optional format for namespaces so that the namespace list appears as a comma-separated line of text. In this case the default is table and the optional choice is text. Modified the definition fo possible output formats to use a OrderedDict as the basis for defining the list of formats for each group and the corresponding default keywords.
KSchopmeyer
force-pushed
the
ks/#594-add-text-outputfmt
branch
from
db0c942
to
fb7bd8a
Compare
andy-maier
approved these changes
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new output format group (TEXT) and modifies two commands to
use this group (server interop, and server brand). This removes the
table option for these commands.
It also implements the text output format as an optional format for
namespaces so that the namespace list appears as a comma-separated
line of text. In this case the default is table and the optional
choice is text.
NOTE: The pr also updates the changes.rst file to add the section
for version 0.7.0 and moves the few changes we have made into
that new section.