Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstings and arg names of InterpolatedVolumeParameter and InterpolatedFlowParameter #890

Merged
merged 2 commits into from
May 22, 2020
Merged

Update docstings and arg names of InterpolatedVolumeParameter and InterpolatedFlowParameter #890

merged 2 commits into from
May 22, 2020

Conversation

Batch21
Copy link
Contributor

@Batch21 Batch21 commented May 21, 2020

No description provided.

@Batch21 Batch21 mentioned this pull request May 21, 2020
Open
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          29       29           
  Lines        2364     2364           
=======================================
  Hits         2065     2065           
  Misses        299      299
Impacted Files Coverage Δ
pywr/parameters/parameters.py 92.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b4e35...8110837. Read the comment docs.

@jetuk
Copy link
Member

jetuk commented May 21, 2020

@Batch21 what have you done here?

@Batch21
Copy link
Contributor Author

Batch21 commented May 22, 2020

oops, I created the branch from the wrong location. Should be fixed after a bit of Git fun.

@jetuk
Copy link
Member

jetuk commented May 22, 2020

Shall we close this then?

@Batch21
Copy link
Contributor Author

Batch21 commented May 22, 2020

Is it not OK as its now branched correctly from master?

@jetuk
Copy link
Member

jetuk commented May 22, 2020

Oh I missed the force push, sorry.

jetuk
jetuk requested changes May 22, 2020
View reviewed changes
Copy link
Member

@jetuk jetuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the variable in InterpolatedFlowParameter.load it currently sets the flows key in a volumes variable which is just confusing.

pywr/parameters/parameters.py Outdated
----------
node: Node
Node to provide input flow values to interpolation caluculation
volumes: array_like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flows.

@jetuk jetuk merged commit f2c39c3 into master May 22, 2020
@jetuk jetuk deleted the fix889 branch May 22, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetuk jetuk jetuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Batch21 @codecov-commenter @jetuk