New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with bucket creation in us-east-1 #113

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
3 participants
@Donohue

Donohue commented Apr 4, 2017

Signed-off-by: Brian Donohue briandonohue@pinterest.com

Brian Donohue
Fix issue with bucket creation in us-east-1
Signed-off-by: Brian Donohue <briandonohue@pinterest.com>
@ooq

This comment has been minimized.

Show comment
Hide comment
@ooq

ooq Apr 4, 2017

Collaborator

@Donohue Thanks for the PR.
Can you provide some descriptions on the issue you are fixing here?

Collaborator

ooq commented Apr 4, 2017

@Donohue Thanks for the PR.
Can you provide some descriptions on the issue you are fixing here?

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Apr 4, 2017

Collaborator

Hey Brian thanks so much for the PR -- does us-east-1 have different bucket creation semantics? @ooq we should probably run our CI in multiple regions to make sure we don't have these bugs.

Collaborator

ericmjonas commented Apr 4, 2017

Hey Brian thanks so much for the PR -- does us-east-1 have different bucket creation semantics? @ooq we should probably run our CI in multiple regions to make sure we don't have these bugs.

@Donohue

This comment has been minimized.

Show comment
Hide comment
@Donohue

Donohue Apr 5, 2017

Hey @ericmjonas and @ooq this ticket describes the issue in detail: boto/boto3#125

Here's the relevant comment for convenience:

This is an artifact of the underlying S3 API and the fact that it doesn't accept us-east-1. To create an S3 bucket in us-east-1 you can just not specify any CreateBucketConfiguration: s3.create_bucket(Bucket='foo').

There was an error creating the bucket in us-east-1 during setup and I verified that this resolves it.

Donohue commented Apr 5, 2017

Hey @ericmjonas and @ooq this ticket describes the issue in detail: boto/boto3#125

Here's the relevant comment for convenience:

This is an artifact of the underlying S3 API and the fact that it doesn't accept us-east-1. To create an S3 bucket in us-east-1 you can just not specify any CreateBucketConfiguration: s3.create_bucket(Bucket='foo').

There was an error creating the bucket in us-east-1 during setup and I verified that this resolves it.

@ooq

This comment has been minimized.

Show comment
Hide comment
@ooq

ooq Apr 5, 2017

Collaborator

@Donohue Indeed! I just tried and verified this as well.
I'm surprised that they haven't fixed it after all this time.

We'll merge your PR after fixing our Travis build. Thanks again.

Collaborator

ooq commented Apr 5, 2017

@Donohue Indeed! I just tried and verified this as well.
I'm surprised that they haven't fixed it after all this time.

We'll merge your PR after fixing our Travis build. Thanks again.

@Donohue

This comment has been minimized.

Show comment
Hide comment
@Donohue

Donohue Apr 5, 2017

Cool 😎

Donohue commented Apr 5, 2017

Cool 😎

@ericmjonas ericmjonas merged commit 5868902 into pywren:master Apr 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Donohue Donohue deleted the Donohue:fix_bucket_creation branch Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment