Skip to content

Fix issue with bucket creation in us-east-1 - #113

Merged
ericmjonas merged 1 commit into
pywren:masterfrom
Donohue:fix_bucket_creation
Apr 7, 2017
Merged

Fix issue with bucket creation in us-east-1#113
ericmjonas merged 1 commit into
pywren:masterfrom
Donohue:fix_bucket_creation

Conversation

@Donohue

@Donohue Donohue commented Apr 4, 2017

Copy link
Copy Markdown

Signed-off-by: Brian Donohue briandonohue@pinterest.com

Signed-off-by: Brian Donohue <briandonohue@pinterest.com>
@ooq

ooq commented Apr 4, 2017

Copy link
Copy Markdown
Collaborator

@Donohue Thanks for the PR.
Can you provide some descriptions on the issue you are fixing here?

@ericmjonas

Copy link
Copy Markdown
Collaborator

Hey Brian thanks so much for the PR -- does us-east-1 have different bucket creation semantics? @ooq we should probably run our CI in multiple regions to make sure we don't have these bugs.

@Donohue

Donohue commented Apr 5, 2017

Copy link
Copy Markdown
Author

Hey @ericmjonas and @ooq this ticket describes the issue in detail: boto/boto3#125

Here's the relevant comment for convenience:

This is an artifact of the underlying S3 API and the fact that it doesn't accept us-east-1. To create an S3 bucket in us-east-1 you can just not specify any CreateBucketConfiguration: s3.create_bucket(Bucket='foo').

There was an error creating the bucket in us-east-1 during setup and I verified that this resolves it.

@ooq

ooq commented Apr 5, 2017

Copy link
Copy Markdown
Collaborator

@Donohue Indeed! I just tried and verified this as well.
I'm surprised that they haven't fixed it after all this time.

We'll merge your PR after fixing our Travis build. Thanks again.

@Donohue

Donohue commented Apr 5, 2017

Copy link
Copy Markdown
Author

Cool 😎

@ericmjonas
ericmjonas merged commit 5868902 into pywren:master Apr 7, 2017
@Donohue
Donohue deleted the fix_bucket_creation branch April 7, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants