Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_local_grid should support eulers as a center #109

Closed
pc494 opened this issue Aug 21, 2020 · 1 comment
Closed

get_local_grid should support eulers as a center #109

pc494 opened this issue Aug 21, 2020 · 1 comment
Assignees
@pc494
Labels
enhancement New feature, request, or improvement
Milestone
v0.3.0

Comments

@pc494
Copy link
Member

pc494 commented Aug 21, 2020

Describe the bug
Currently (well soon-to-be-currently, as in #104) the get_local_grid only accepts orix objects as center, we should allow (x1,z,x2) as (diffsims convention consistent) euler rotations
@pc494 pc494 added the enhancement New feature, request, or improvement label Aug 21, 2020
@pc494 pc494 self-assigned this Aug 21, 2020
@pc494 pc494 mentioned this issue Sep 1, 2020
Closed
3 tasks
@pc494 pc494 added this to the v0.3.0 milestone Sep 3, 2020
@pc494 pc494 mentioned this issue Sep 3, 2020
Merged
@pc494
Copy link
Member Author

pc494 commented Sep 4, 2020

#115 closed this

@pc494 pc494 closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pc494 pc494

Labels
enhancement New feature, request, or improvement
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@pc494