-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gridding #104
Remove gridding #104
Conversation
These are going to involve renaming some functions, which we should keep track of. I think the diffsims versions will be called |
I think this in a merge-worthy state, and I've raised issues for the components that have been damaged/left unimproved. Would be nice to get this in to help with merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pc494 always nice to see the maintenance burden drop for a change :)
name: Remove gridding, closes #100
about: As discussed elsewhere, we are moving the gridding functionality to
orix
, this PR implements that indiffsims
In Scope
orix
portsand raise a(FZ gridding and local gridding)DeprecationWarning
rotation_list_generator.py
, for example beam_direction grids (currently ingridding_utils.py
)v0.3
?Any associate tidy ups, including those that relate to get_grid_stereographic() for rotation_list_generators seems to have a bug for input ('cubic' #103, (in beam direction form)Change howget_beam_direction
copes with the cubic case to improve brevity