Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gridding #104

Merged
merged 23 commits into from
Aug 21, 2020
Merged

Remove gridding #104

merged 23 commits into from
Aug 21, 2020

Conversation

pc494
Copy link
Member

@pc494 pc494 commented Jul 31, 2020


name: Remove gridding, closes #100
about: As discussed elsewhere, we are moving the gridding functionality to orix, this PR implements that in diffsims


In Scope

@pc494
Copy link
Member Author

pc494 commented Aug 3, 2020

These are going to involve renaming some functions, which we should keep track of. I think the diffsims versions will be called get_xyz_grid_list and the orix version get_xyz_grid

@dnjohnstone dnjohnstone added this to the v0.3.0 milestone Aug 20, 2020
@dnjohnstone dnjohnstone added dev enhancement New feature, request, or improvement labels Aug 20, 2020
@dnjohnstone dnjohnstone linked an issue Aug 20, 2020 that may be closed by this pull request
@dnjohnstone dnjohnstone mentioned this pull request Aug 20, 2020
3 tasks
@pc494 pc494 marked this pull request as ready for review August 20, 2020 19:08
@pc494
Copy link
Member Author

pc494 commented Aug 21, 2020

I think this in a merge-worthy state, and I've raised issues for the components that have been damaged/left unimproved. Would be nice to get this in to help with merge conflicts.

Copy link
Member

@dnjohnstone dnjohnstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pc494 always nice to see the maintenance burden drop for a change :)

@dnjohnstone dnjohnstone merged commit 8482796 into pyxem:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev enhancement New feature, request, or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration of grid functionality to orix
2 participants