Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readthedocs diffsims API documentation? #126

Closed
hakonanes opened this issue Sep 23, 2020 · 5 comments · Fixed by #127
Closed

Readthedocs diffsims API documentation? #126

hakonanes opened this issue Sep 23, 2020 · 5 comments · Fixed by #127
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature, request, or improvement question Further information is requested
Milestone

Comments

@hakonanes
Copy link
Member

kikuchipy now depends on diffsims for electron scattering and diffraction (namely the crystallography.ReciprocalLatticePoint class): pyxem/kikuchipy#220. I would therefore want the diffsims API to be easily browsable like kikuchipy's (https://kikuchipy.org/en/latest/reference.html) or orix' (https://orix.readthedocs.io/en/stable/reference.html).

The intersphinx functionality (click e.g. on the Rotation link in the "Parameters" docstring here: https://kikuchipy.org/en/latest/reference.html#kikuchipy.generators.EBSDSimulationGenerator) is also very nice, which becomes more important as kikuchipy depends more and more on orix (and hopefully diffsims).

I volunteer to set up a simple Readthedocs documentation available via https://diffsims.rtfd.io, as I did for orix.

@hakonanes hakonanes added documentation Improvements or additions to documentation enhancement New feature, request, or improvement question Further information is requested labels Sep 23, 2020
@hakonanes hakonanes added this to the v0.4.0 milestone Sep 23, 2020
@hakonanes hakonanes self-assigned this Sep 23, 2020
@hakonanes hakonanes changed the title Readthedocs diffsims API documentation Readthedocs diffsims API documentation? Sep 23, 2020
@pc494
Copy link
Member

pc494 commented Sep 23, 2020

Yes please @hakonanes, that would be great :)

@pc494
Copy link
Member

pc494 commented Sep 24, 2020

Would this still work if we released it at a patch level? If so could we include it as well as the fix to #125 + whatever I find when making the demos into a 0.3.1?

@hakonanes
Copy link
Member Author

Yes, shouldn't be a problem. Readthedocs only needs a config file and a doc directory to build from.

@hakonanes hakonanes modified the milestones: v0.4.0, v0.3.1 Sep 24, 2020
@hakonanes
Copy link
Member Author

Made a v0.3.1 patch milestone to keep track of that release.

@pc494
Copy link
Member

pc494 commented Sep 24, 2020

Great stuff, thank you :)

@pc494 pc494 modified the milestones: v0.3.1, v0.4.0 Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature, request, or improvement question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants