Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diffsims for electron scattering and diffraction #220

Conversation

hakonanes
Copy link
Member

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

  • Depend on diffsims (https://github.com/pyxem/diffsims) for scattering/diffraction stuff, namely the ReciprocalLatticePoint class to handle crystal planes, used by the EBSDSimulationGenerator and GeometricalEBSDSimulation classes in kikuchipy.
  • Remove the identical ReciprocalLatticePoint class in kikuchipy, and related functionality which is in diffsims. This increases code coverage to 97%!
  • Add changelog entry.

Closes #212.

Progress of the PR

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the maintenance This relates to package maintenance label Sep 23, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Sep 23, 2020
@hakonanes hakonanes self-assigned this Sep 23, 2020
@hakonanes
Copy link
Member Author

Will merge after tests pass.

@hakonanes hakonanes merged commit f39bd4b into pyxem:master Sep 23, 2020
@hakonanes hakonanes deleted the diffsims-dependency-remove-reciprocallatticepoint branch September 23, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the ReciprocalLatticePoint class and structure factor calculations from diffsims
1 participant