Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Option to add labels in simulation diffraction spots
Release Notes
What does this PR do? Please describe and/or link to an open issue.
After discussion in #170 I thought I would open this small PR for adding the option to draw the miller indices of spot patterns. With this change it is now possible to do the following:
Does this approach what you had in mind @CSSFrancis ?
Apparently there are also two small additions: the option to mirror pattern masks and the update to the stereo triangle for the hex system. It seems this was not merged before, see #168
Are there any known issues? Do you need help?
I would have liked to create a vectorized implementation but have no idea if this is possible with strings. Probably one could do some smart tricks with string formatting, but I couldn't figure out how to do that with the
\bar{}
on negative indices. If anyone has a better implementation idea feel free to modify.Work in progress?
If you know there is more to do, make a checklist here:
For reviewers
later.
__init__.py
.the unreleased section in
CHANGELOG.md
.