-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add computing of image quality, chunk/pattern modules, some FFT wrappers ++ #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…image-quality Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…ence Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Yes, this is a large PR... But the majority of lines reported are the SVG files for the new logo. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…eased Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
This relates to the documentation
enhancement
New feature or request
maintenance
This relates to package maintenance
tests
This relates to the tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds:
get_image_quality()
(following Krieger Lassen, see docstring for reference),get_dynamic_background()
,fft_filter()
, andnormalize_intensity()
to theEBSD
class.kikuchipy.util.barnes
, the latter taken from Connelly Barnes' fftfilter.pykikuchipy.util.chunk
andkikuchipy.util.pattern
modules. These were previously private, but are now part of the public API.kikuchipy.util.Window
class, with three windows: modified Hann, lowpass FFT filter, and highpass FFT filter, all used by Wilkinson et al. (2006) "High resolution mapping..." (see reference in docstrings). These work nicely withfft_filter()
. Note that this class was previously calledKernel
. Also new is that it is subclassingnumpy.ndarray
.remove_dynamic_background()
can now create the dynamic background to remove either via a Gaussian filter in real or frequency space, viascipy.ndimage.gaussian_filter()
as before, or via thekikuchipy.util.barnes.fft_filter()
. The latter is faster.Renames methods:
EBSD.static_background_correction
->EBSD.remove_static_background
EBSD.dynamic_background_correction
->EBSD.remove_dynamic_background
EBSD.rescale_intensities
->EBSD.rescale_intensity
A Numba dependency is introduced to speed up some computations, like pattern intensity rescaling used in
kikuchipy.util.pattern.rescale_intensity
,kikuchipy.util.chunk.rescale_intensity
, orkikuchipy.signals.ebsd.EBSD.rescale_intensity
. In addition, some speed is gained in other routines due to improved use of Dask and a reduction in necessary computations.Some CSS modifications to the RTD theme has also been done.
The new and changed functionality has been updated in the documentation.
Type of change
Progress
EBSD
methods have been testedkikuchipy.util.chunk
functions have been testedHow has this been tested?