Use numpy.fft instead of scipy.fft #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes
added
bug
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes
added a commit
to hakonanes/kikuchipy
that referenced
this pull request
May 20, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes
added a commit
that referenced
this pull request
May 20, 2020
* Cherry-pick #180 Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com> * Get changelog updates from v0.2.1 in Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com> * Add PR link to changelog Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com> * Fix PR link Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com
Description
Tries to fix #179. HyperSpy requires scipy < 1.4 on conda-forge. We started using scipy.fft in v0.2.0 for FFT filtering, but that was introduced in scipy 1.4. Have therefore removed scipy > 1.4 requirement in setup.py and started switched to numpy.fft until HyperSpy removes scipy < 1.4 requirement on conda-forge.
This might affect some of the routines using FFT (image quality calculation, FFT filtering, dynamic background correction, getting the dynamic background).
Also stopped using selectors (dask[array], hyperspy[learning]) and reintroduced scikit-learn as a dependency.
Checklist
For reviewers
later.
__init__.py.the unreleased section in
doc/changelog.rst.