Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scikit-image >= 0.16, fix related adaptive histogram test #196

Merged

Conversation

hakonanes
Copy link
Member

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description

The test kikuchipy/pattern/tests/test_chunk.py::TestAdaptiveHistogramEqualizationChunk::test_adaptive_histogram_equalization_chunk failed with scikit-image 0.17.2, while passed for 0.16.2.

This PR:

  • Allow scikit-image >= 0.16 in setup.py
  • Ensure mentioned test pass for both scikit-image versions 0.16 and 0.17. This fix leads to a coverage reduction of one line when running the test suite with scikit-image 0.16... But that is acceptable.

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the maintenance This relates to package maintenance label Aug 7, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Aug 7, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8556c65 on hakonanes:fix-adaptive-histogram-test-skimage into 778da53 on kikuchipy:master.

@hakonanes hakonanes merged commit 9a8e361 into pyxem:master Aug 7, 2020
@hakonanes hakonanes deleted the fix-adaptive-histogram-test-skimage branch August 7, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants