Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete tests for EBSDSimulationGenerator #219

Merged

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Sep 22, 2020

Description of the change

  • Finish preliminary testing of kikuchipy.generators.EBSDSimulationGenerator. (More test cases might be added when finishing testing of other functionality not currently tested.)
  • Improve calculation of Kikuchi band detector coordinates using numpy.tensordot
  • Remove (for now) unnecessary reciprocal_lattice_point parameter when initializing a kikuchipy.simulations.GeometricalEBSDSimulation (phase with crystal structure, symmetry operations etc., hkl/Miller planes etc. are stored within the kikuchipy.simulations.features.KikuchiBand object)
  • Add EBSDSimulationGenerator to API reference
  • Set up intersphinx with orix, so that docstring references in kikuchipy to orix points directly to relevant elements in https://orix.readthedocs.io/en/stable/reference.html

Progress of the PR

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added enhancement New feature or request documentation This relates to the documentation tests This relates to the tests labels Sep 22, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Sep 22, 2020
@hakonanes hakonanes self-assigned this Sep 22, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit 8970d1d into pyxem:master Sep 22, 2020
@hakonanes hakonanes deleted the document-test-geometrical-simulation branch September 22, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This relates to the documentation enhancement New feature or request tests This relates to the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant