Skip to content

Add EBSD.xmap class property storing a CrystalMap, read from EMsoft EBSD file#226

Merged
hakonanes merged 2 commits into
pyxem:masterfrom
hakonanes:add-xmap-property-to-ebsd
Oct 1, 2020
Merged

Add EBSD.xmap class property storing a CrystalMap, read from EMsoft EBSD file#226
hakonanes merged 2 commits into
pyxem:masterfrom
hakonanes:add-xmap-property-to-ebsd

Conversation

@hakonanes

@hakonanes hakonanes commented Sep 30, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

  • Add EBSD.xmap class property storing a CrystalMap
  • Read orientations and phase information from EMsoft simulated EBSD file into this xmap property
  • Add short note in IO user guide

Must be added in other PRs:

  • Make property setable
  • Slice xmap when slicing a signal using s.inav[]
  • Read this info from TSL/Bruker h5ebsd files.

This was added quickly now because @onatlandsmyr needs it.

The _crystaldata2phase() IO function should be moved to orix.io.plugins.emsoft_h5ebsd.

Progress of the PR

Minimal example of the bug fix or new feature

>>> import kikuchipy as kp
>>> s = kp.load("my_data.h5")
>>> s.xmap
Phase  Orientations  Name  Space group  Point group  Proper point group     Color
    0  200 (100.0%)    ni        Fm-3m         m-3m                 432  tab:blue

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the enhancement New feature or request label Sep 30, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Sep 30, 2020
@hakonanes hakonanes self-assigned this Sep 30, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit b31781d into pyxem:master Oct 1, 2020
@hakonanes hakonanes deleted the add-xmap-property-to-ebsd branch October 1, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant