Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMsoft EBSD master pattern plugin can read a single energy, change energy parameter name #240

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Oct 29, 2020

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

  • An EMsoft master pattern file with a single beam energy pattern (e.g. only 20 keV) can now be read
  • The energy_range parameter to the EMsoft master pattern reader is therefore changed to energy (in code and tests)
  • Necessary updates to the tests and documentation are added.

This functionality is needed before PR #237 can progress, as a modified (uint8, not float32) single beam energy master pattern file is planned to be included in the kikuchipy.data module.

Progress of the PR

Minimal example of the bug fix or new feature

All these values to energy is now allowed:

>>> import kikuchipy as kp
>>> mp = kp.load("my/data.h5", energy=20)
>>> mp2 = kp.load("my/data.h5", energy=(10, 20))
>>> mp3 = kp.load("my/data.h5", energy=None)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

…e energy

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the enhancement New feature or request label Oct 29, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Oct 29, 2020
@hakonanes hakonanes self-assigned this Oct 29, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes changed the title Change EMsoft MP plugin param energy_range->energy, enable reading single energy EMsoft EBSD master pattern plugin can read a single energy, change "energy_range" parameter name to "energy" Oct 30, 2020
@hakonanes hakonanes changed the title EMsoft EBSD master pattern plugin can read a single energy, change "energy_range" parameter name to "energy" EMsoft EBSD master pattern plugin can read a single energy, change energy parameter name Oct 30, 2020
@hakonanes hakonanes merged commit 2bff7bc into pyxem:master Oct 30, 2020
@hakonanes hakonanes deleted the read-masterpattern-single-energy branch October 30, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant