Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in getting plot markers from geometrical EBSD simulation #334

Merged
merged 4 commits into from
Apr 15, 2021

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Apr 15, 2021

Description of the change

Added tests to catch these two cases.

Close #318.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added bug Something isn't working 👈 backport labels Apr 15, 2021
@hakonanes hakonanes added this to the v0.3.3 milestone Apr 15, 2021
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit d28a062 into pyxem:master Apr 15, 2021
@hakonanes hakonanes deleted the fix-318 branch April 15, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant