Allow not passing simulation indices property array to crystal map merging #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The fact that we now have to pass
simulation_indices_prop
tomerge_crystal_maps()
in order to get the simulation indices in the merged map, instead of getting these by default, is breaking the API. However, I will ignore that fact and include this in the forthcoming v0.3.3 patch release.Progress of the PR
Minimal example of the bug fix or new feature
The following didn't work previously, but now works
For reviewers
__init__.py
.unreleased section in
doc/changelog.rst
.