Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reader of EBSD patterns from Oxford binary .ebsp files #371

Merged
merged 10 commits into from
Jun 21, 2021

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Jun 17, 2021

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

Add reader of EBSD patterns from Oxford binary .ebsp files:

>>> import kikuchipy as kp
>>> s = kp.load("patterns.ebsp", navigation_shape=(40, 50))  # (n rows, n columns)
>>> s.plot()

As far as I know, the navigation shape is not contained within the file, so that must be provided.

I hope to add a writer to this format as well, in a separate PR.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the enhancement New feature or request label Jun 17, 2021
@hakonanes hakonanes added this to the v0.4.0 milestone Jun 17, 2021
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Copy link
Member Author

So, the tests for the Oxford binary reader failed on Windows because I passed int to numpy.fromfile dtype parameter, and not int64, which I should have. int apparently meant int32 on the Windows test server.

@hakonanes hakonanes merged commit 4992625 into pyxem:master Jun 21, 2021
@hakonanes hakonanes deleted the oxford-binary-format-reader branch June 21, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant