Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static background in metadata to be a Dask array #413

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

hakonanes
Copy link
Member

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

After v0.5 has been released, bug fixes such as this should be branched off of main and merged back into main, possibly with the necessary patch release updates (changelog, patch version increment) included so we could release a patch release immediately.

Progress of the PR

Minimal example of the bug fix or new feature

The following doesn't throw a TypeError

>>> import kikuchipy as kp
>>> import dask.array as da
>>> s = kp.data.nickel_ebsd_small()
>>> s.metadata.Acquisition_instrument.SEM.Detector.EBSD.static_background = da.from_array(s.metadata.Acquisition_instrument.SEM.Detector.EBSD.static_background)
>>> s.remove_static_background()

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in doc/changelog.rst.
  • New contributors are added to .all-contributorsrc and the table is regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Aug 19, 2021
@hakonanes hakonanes added this to the v0.5.0 milestone Aug 19, 2021
@hakonanes hakonanes merged commit 6277a28 into pyxem:develop Aug 19, 2021
@hakonanes hakonanes deleted the fix-399 branch August 19, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the static background in EBSD metadata to be a dask array in EBSD.remove_static_background()
1 participant