Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate instead of removing three chunk processing functions #533

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

hakonanes
Copy link
Member

Description of the change

Reintroduce the kikuchipy.pattern.chunk functions remove_static_background(), remove_dynamic_background() and get_image_quality(), which were removed in #527. Better to deprecate and remove in v0.7.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to .all-contributorsrc and the table is regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the deprecation Deprecated functionality label Jun 2, 2022
@hakonanes hakonanes added this to the v0.6.0 milestone Jun 2, 2022
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit c5df967 into pyxem:develop Jun 2, 2022
@hakonanes hakonanes deleted the reintroduce-chunk-processing branch June 2, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecated functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant