-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle custom EBSD class attributes in calls to Signal2D's inav, isig and more #578
Merged
hakonanes
merged 22 commits into
pyxem:develop
from
hakonanes:further-improve-use-custom-ebsd-attributes
Nov 16, 2022
Merged
Handle custom EBSD class attributes in calls to Signal2D's inav, isig and more #578
hakonanes
merged 22 commits into
pyxem:develop
from
hakonanes:further-improve-use-custom-ebsd-attributes
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
83ceaa6
to
df1659c
Compare
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Attempt to crop and update
EBSD
class attributesxmap
(an orixCrystalMap
),static_background
anddetector
(anEBSDDetector
) upon calls to the following inherited methods from HyperSpy'sSignal2D
methods:inav
(cropxmap
andEBSDDetector.pc
)isig
(cropEBSDDetector.shape
andstatic_background
)crop()
(crop attributes)crop_image()
(cropEBSDDetector.shape
andstatic_background
)rebin()
(if nav dimensions change, thexmap
andEBSDDetector.pc
values are lost; if only sig dimensions change,EBSDDetector.pc
values are lost while thestatic_background
is binned similarly to the signal)Handling of attributes in
inav
andisig
is done by overwriting the privateBaseSignal._slicer()
method. This is dangerous, however most handling is done via try/except, falling back to old behavior if this doesn't work. Tests, my own testing and building the docs' tutorials and examples runs as desired.Other changes:
nickel_ebsd_small()
dataset HDF5 file. Indexing and PC refinement was done first with PyEBSDIndex, then usingrefine_orientation_projection_center()
.Closes #227.
Progress of the PR
rebin()
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
,.zenodo.json
and.all-contributorsrc
with the table regenerated.