Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading of Oxford Instruments binary .ebsp files of version 4 #602

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

hakonanes
Copy link
Member

Description of the change

This fix ensures Oxford Instruments' binary .ebsp files of version 4 can be read by skipping an extra byte (uint8) after the file version. When accounting for this extra byte, patterns are read correctly as before. This fixes #591.

Thanks to @drowenhorst-nrl for this insight.

I don't know what this extra byte is, but it is 0 (when read as uint8) in the file I have access to.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Feb 3, 2023
@hakonanes hakonanes added this to the v0.8.0 milestone Feb 3, 2023
@hakonanes hakonanes merged commit 30dba35 into pyxem:develop Feb 3, 2023
@hakonanes hakonanes deleted the oxford-ebsp-version4 branch February 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read Oxford's binary .ebsp files with version 4
1 participant