Fix reading of Oxford Instruments binary .ebsp files of version 4 #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This fix ensures Oxford Instruments' binary .ebsp files of version 4 can be read by skipping an extra byte (uint8) after the file version. When accounting for this extra byte, patterns are read correctly as before. This fixes #591.
Thanks to @drowenhorst-nrl for this insight.
I don't know what this extra byte is, but it is 0 (when read as uint8) in the file I have access to.
Progress of the PR
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
,.zenodo.json
and.all-contributorsrc
with the table regenerated.