Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default EBSD.detector attribute shape when detector is not passed upon initialization #603

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

hakonanes
Copy link
Member

Description of the change

Fix default EBSD.detector attribute shape when detector is not passed upon initialization.

Progress of the PR

Minimal example of the bug fix or new feature

>>> import numpy as np
>>> import kikuchipy as kp
>>> s = kp.signals.EBSD(np.ones((1, 2, 3, 4))
>>> s.detector.shape
(3, 4)  # (4, 3) before this fix (ouch!)

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
… col)

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Feb 3, 2023
@hakonanes hakonanes added this to the v0.8.0 milestone Feb 3, 2023
@hakonanes hakonanes merged commit e9eead9 into pyxem:develop Feb 3, 2023
@hakonanes hakonanes deleted the fix-default-ebsd-detector-shape branch February 3, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant