Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EDAX-Bruker (PCy, PCz) conversion for rectangular detectors #604

Closed
wants to merge 3 commits into from

Conversation

hakonanes
Copy link
Member

Description of the change

This PR changes the EDAX->Bruker (PCy, PCz) conversion for rectangular detectors. The correct conversion is as follows:

PCy = 1 - y*/Ny
PCz = z* / min(Nx, Ny)

where (PCy, PCz) are the Bruker projection center (PC) y and z coordinates, (Nx, Ny) are the number of detector columns and rows, and (y*, z*) are the EDAX TSL PC y and z coordinates.

The Oxford->Bruker conversion stays the same.

This change follows the same change coming in a new version of PyEBSDIndex (relevant commit drowenhorst-nrl/PyEBSDIndex@ea22dfd). Hence, we should wait to merge this until a new version of PyEBSDIndex is available with this change.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Feb 4, 2023
@hakonanes hakonanes added this to the v0.8.1 milestone Feb 10, 2023
@hakonanes hakonanes modified the milestones: v0.8.1, v0.8.2 Feb 20, 2023
@hakonanes hakonanes modified the milestones: v0.8.2, v0.8.3 Mar 14, 2023
@hakonanes hakonanes removed this from the v0.8.3 milestone Mar 23, 2023
@hakonanes hakonanes marked this pull request as draft April 7, 2023 12:23
@hakonanes
Copy link
Member Author

This PR will be added to another PR preparing a 0.9 release compatible with PyEBSDIndex v0.2.

@hakonanes hakonanes closed this Aug 8, 2023
@hakonanes hakonanes removed the bug Something isn't working label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant