Fix EDAX-Bruker (PCy, PCz) conversion for rectangular detectors #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR changes the EDAX->Bruker (PCy, PCz) conversion for rectangular detectors. The correct conversion is as follows:
PCy = 1 - y*/Ny
PCz = z* / min(Nx, Ny)
where (PCy, PCz) are the Bruker projection center (PC) y and z coordinates, (Nx, Ny) are the number of detector columns and rows, and (y*, z*) are the EDAX TSL PC y and z coordinates.
The Oxford->Bruker conversion stays the same.
This change follows the same change coming in a new version of PyEBSDIndex (relevant commit drowenhorst-nrl/PyEBSDIndex@ea22dfd). Hence, we should wait to merge this until a new version of PyEBSDIndex is available with this change.
Progress of the PR
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
,.zenodo.json
and.all-contributorsrc
with the table regenerated.