Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimal version of orix to >= 0.11.1 #623

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Conversation

Erlendos12
Copy link
Contributor

@Erlendos12 Erlendos12 commented Mar 14, 2023

Description of the change

Set minimal version of orix to >= 0.11.1

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • [n/a] New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Version 0.11.1 includes a bug fix for where phases were losing information after refinement from single crystal map.
@hakonanes hakonanes added the bug Something isn't working label Mar 14, 2023
@hakonanes hakonanes added this to the v0.8.2 milestone Mar 14, 2023
@hakonanes
Copy link
Member

Thank you for reporting #620 which lead to the fix in orix 0.11.1 and then this PR!

Would be nice if you could add a one-liner under "Changed" in CHANGELOG.rst as well.

I'll add your name (Erlend Mikkelsen Østvold) to the package credits in kikuchipy/release.py and .zenodo.json (NTNU as your affiliation) as well as the contributors table in the README to this PR. Is this OK with you?

@Erlendos12
Copy link
Contributor Author

Thank you for reporting #620 which lead to the fix in orix 0.11.1 and then this PR!

Would be nice if you could add a one-liner under "Changed" in CHANGELOG.rst as well.

I'll add your name (Erlend Mikkelsen Østvold) to the package credits in kikuchipy/release.py and .zenodo.json (NTNU as your affiliation) as well as the contributors table in the README to this PR. Is this OK with you?

Yes! I thought maybe I had to create the pull request first in order to refer to it in the changelog. I am ok with being added to contributers, thank you.

@hakonanes
Copy link
Member

True, the manual way we create the changelog isn't perhaps the most convenient... I determine the next GitHub repo ID by checking the latest IDs among issues, PRs and discussions. But this procedure isn't written anywhere...

Just ping me when the PR is ready for review (should be quick)!

@Erlendos12
Copy link
Contributor Author

@hakonanes The PR should be ready for review now!:)

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Copy link
Member

Next time, I suggest to name your branch something else than develop or main, which is a little bit easier to keep track of when pulling your changes locally. (Lots to think about...)

@hakonanes hakonanes merged commit 92e52a9 into pyxem:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants