Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions #656

Merged
merged 2 commits into from Nov 3, 2023
Merged

Conversation

hakonanes
Copy link
Member

Description of the change

This PR removes the following deprecated datasets from the kikuchipy.data module:

  • silicon_ebsd_moving_screen_in()
  • silicon_ebsd_moving_screen_out5mm()
  • silicon_ebsd_moving_screen_out10mm()

They were deprecated in v0.8 and replaced by si_ebsd_moving_screen(distance).

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

@hakonanes hakonanes added the deprecation Deprecated functionality label Nov 3, 2023
@hakonanes hakonanes added this to the v0.9.0 milestone Nov 3, 2023
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes mentioned this pull request Nov 3, 2023
@hakonanes hakonanes merged commit 6f69722 into pyxem:develop Nov 3, 2023
12 checks passed
@hakonanes hakonanes deleted the remove-unused-functions branch November 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecated functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant